Skip to content

feat: add assert/is-float16array #7273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 8, 2025
Merged

feat: add assert/is-float16array #7273

merged 13 commits into from
Jul 8, 2025

Conversation

udaykakade25
Copy link
Contributor

@udaykakade25 udaykakade25 commented Jun 8, 2025 •
edited by kgryte
Loading

Progresses stdlib-js/google-summer-of-code#94

Description

What is the purpose of this pull request?

This pull request:

  • Add assert/is-float16array

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves itself

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jun 8, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jun 8, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
assert/is-float16array $\color{green}105/105$
$\color{green}+100.00\%$ 		$\color{red}3/4$
$\color{green}+75.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}105/105$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

ShabiShett07
ShabiShett07 reviewed Jun 8, 2025
View reviewed changes
ShabiShett07
ShabiShett07 reviewed Jun 8, 2025
View reviewed changes
ShabiShett07
ShabiShett07 reviewed Jun 8, 2025
View reviewed changes
@ShabiShett07
Copy link
Contributor

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jun 8, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jun 8, 2025
@udaykakade25
Copy link
Contributor Author

Hello @kgryte sir,
Here's assert/is-float16array.
As per your directions, I skipped test cases for test/test.js, examples/index.js, and benchmark/bechmark.js that require float16.
Can you take a look at docs/types? I think the rest is implemented correctly.

Planeshifter
Planeshifter reviewed Jun 10, 2025
View reviewed changes
Planeshifter
Planeshifter reviewed Jun 10, 2025
View reviewed changes
@udaykakade25 udaykakade25 mentioned this pull request Jun 13, 2025
Merged
1 task
@udaykakade25 udaykakade25 mentioned this pull request Jun 21, 2025
Open
1 task
@udaykakade25
Update README.md
5821d4b 
Signed-off-by: Uday Kakade <[email protected]>
@udaykakade25
Update benchmark.js
f684ff3 
Signed-off-by: Uday Kakade <[email protected]>
@udaykakade25
Update main.js
9cf8ac6 
Signed-off-by: Uday Kakade <[email protected]>
@udaykakade25
Update repl.txt
34b721a 
Signed-off-by: Uday Kakade <[email protected]>
@udaykakade25
Update README.md
93e8d5a 
Signed-off-by: Uday Kakade <[email protected]>
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Jul 8, 2025
@kgryte kgryte self-requested a review July 8, 2025 07:33
@kgryte
chore: clean-up
fa8d23d 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jul 8, 2025
kgryte
kgryte approved these changes Jul 8, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this package should have been added after first adding array/float16. Adding this prior to array/float16 just means that we'll need to revisit this package and refactor accordingly. In the interim, I've added various placeholder TODOs.

@kgryte kgryte merged commit 77b2415 into stdlib-js:develop Jul 8, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter left review comments

@ShabiShett07 ShabiShett07 ShabiShett07 left review comments

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@udaykakade25 @stdlib-bot @ShabiShett07 @Planeshifter @kgryte